bundle-kubeflow icon indicating copy to clipboard operation
bundle-kubeflow copied to clipboard

Merge the `deploy-1.8.sh` and `deploy-1.9.sh` scripts for deploying airgapped into one

Open mvlassis opened this issue 1 year ago • 1 comments

Context

At the moment of writing, we support versions 1.8 and 1.9 of Charmed Kubeflow. For deploying on an airgapped instance, we have create 2 scripts named deploy-1.8.sh and deploy-1.9.sh that do so on the respective version.

The two scripts have the same structure and very similar commands, differing only in some deploy and relate commands. Thus, they could be merged into a single script named deploy.sh or deploy-airgapped.sh that receives an argument for the version to deploy ("1.8" or "1.9") and call the appropriate function. This reduces the total code base and the amount of files on the repository.

The script could also be written in Python (pinging @kimwnasptd for his opinion).

What needs to get done

  • Create a script called deploy.sh under scripts/airgapped that receives a single argument for the version (in our case "1.8" and "1.9"), and deploys that version of Charmed Kubeflow.
  • Delete deploy-1.8.sh and deploy-1.9.sh as they are no longer needed.

Definition of Done

The script deploy.sh completely replaces deploy-1.8.sh and deploy-1.9.sh meaning that it can be called with the following arguments:

  • Running deploy.sh "1.9" is the same as currently running deploy-1.9.sh.
  • Running deploy.sh "1.8" is the same as currently running deploy-1.8.sh.

mvlassis avatar Sep 23 '24 09:09 mvlassis

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6289.

This message was autogenerated