apport icon indicating copy to clipboard operation
apport copied to clipboard

Rename apport/packaging.py to apport/package_info.py

Open bdrung opened this issue 10 months ago • 1 comments

import apport.packaging will not import apport/packaging.py but packaging from apport/__init__.py instead. To avoid this name clash name the Python file identical to the class it defines.

It is expected that no Python code outside of Apport uses from apport.packaging import PackageInfo.

Fixes: 8763b83047a9 ("Changed the packaging backend import, [...]")

bdrung avatar Mar 14 '25 17:03 bdrung

Codecov Report

Attention: Patch coverage is 69.04762% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (fb01bbb) to head (902e8e4). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
apport/package_info.py 67.50% 24 Missing and 2 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         102      102           
  Lines       20723    20724    +1     
  Branches     3251     3251           
=======================================
+ Hits        17426    17427    +1     
  Misses       2847     2847           
  Partials      450      450           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 14 '25 18:03 codecov[bot]

The failing codecov/patch can be ignored.

bdrung avatar May 31 '25 13:05 bdrung

Please resolve the conflicts.

schopin-pro avatar Jun 02 '25 17:06 schopin-pro

Rebased and conflict resolved.

bdrung avatar Jun 02 '25 18:06 bdrung