can-connect icon indicating copy to clipboard operation
can-connect copied to clipboard

corejs causes conflict with can-connect

Open tracer99 opened this issue 8 years ago • 4 comments

We have an issue with our DoneJS project where IE11 routing doesn't work under some conditions. Based on recomendation by one of your devs on gitter, we include corejs in our main app file.

import "core-js/client/core";

This has been running fine in production for months.

We didn't try to use Models until recently, but it appears that just importing can-connect causes the app to crash

import superMap from 'can-connect/can/super-map/';

See this revision of an example of this in action

The error output is TypeError: Cannot read property 'push' of undefined which I was not able to successfully debug.

Depending on what page is loaded when, this error will either take down the server or throw an error in the client.

tracer99 avatar Feb 03 '17 20:02 tracer99

@tracer99 Do you have the gitter conversation? Do you know why the dev recommended it or which developer it was?

Have you tried this with a 1.X version of can-connect?

Thanks!

justinbmeyer avatar Feb 03 '17 21:02 justinbmeyer

Here is the start of the conversation: https://gitter.im/donejs/donejs?at=57a0b4891c2bf6621bb598b0.

phillipskevin avatar Feb 03 '17 21:02 phillipskevin

@justinbmeyer It's a DoneJS project, so I'm assuming that trying to upgrade can-connect in isolation will not go well?

tracer99 avatar Feb 03 '17 22:02 tracer99

@tracer99 any updates on this? I'm trying to clean up old issues. Thanks!

justinbmeyer avatar Jun 02 '18 02:06 justinbmeyer