dungeon-sheets icon indicating copy to clipboard operation
dungeon-sheets copied to clipboard

Published 20 hours ago • verified publisher icon canismarko

Switch pdfrw to pypdf

Open PJBrs opened this issue 6 months ago • 0 comments

This PR has three patches that improve pdf handling in the absence of pdftk. This lays some further groundwork for getting rid of pdftk in the future, and it gets rid of pdfrw now.

The first patch adds fallback merging separate pdfs with pypdf. The second patch moves fallback pdf filling code from pdfrw to pypdf. The last patch silences a (harmless) warning from the fillable personality sheet.

The pdfrw code for filling a pdf form contained a bug as well, which is fixed with this PR.

PJBrs avatar Aug 23 '24 11:08 PJBrs