champ-r icon indicating copy to clipboard operation
champ-r copied to clipboard

Fixes for Linux on 2.0 version

Open NogradThGin opened this issue 1 year ago • 2 comments

Hello, some errors got into the code :yum:

Both on cmd.rs file.
First at line 18, there is 2 double quote a the end.
Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap();
Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69:
Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#;
Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for MacOS, I don't know. But as far as I tested, it doesn't work on Linux.

NogradThGin avatar Jun 22 '23 19:06 NogradThGin

Hi, thx for your feedback, ps -A | grep LeagueClientUx | grep remoting-auth-token= is actually for macOS. Sorry I don't have a linux OS on my pc, since you have already there, contributions are welcome 😄

cangzhang avatar Jun 23 '23 05:06 cangzhang

Hello! I'm willing to test the building and running under Linux, but I'd appreciate some help in compiling the package.

Hello, some errors got into the code

Both on cmd.rs file. First at line 18, there is 2 double quote a the end. Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap(); Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69: Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#; Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for Faggot_Os, I don't know. But as far as I tested, it doesn't work on Linux.

I've applied those changes but the build fails.

I'm using cargo b --target "x86_64-unknown-linux-gnu" but the app crashes after selecting sources and it does not detect league

EatedPantsu avatar Jan 21 '24 15:01 EatedPantsu