champ-r icon indicating copy to clipboard operation
champ-r copied to clipboard

添加Champion Rankings数据

Open diaolingzc opened this issue 3 years ago • 2 comments

添加Champion Rankings数据 image

diaolingzc avatar Nov 30 '21 14:11 diaolingzc

This whole idea is good, thanks. But:

  1. op.gg is not always available for china mainland visitors, so this window may not work properly as expected.
  2. everything in this window is readonly, I don't think that makes sense.
  3. I don't think taking everything from op.gg (or other platforms) is a good thing. (maybe you can convince me about it.)

cangzhang avatar Nov 30 '21 15:11 cangzhang

Regarding your three questions:

  1. the problem of op.gg access, I think it can be solved by data crawler, just like https://github.com/champ-r/data-crawler.
  2. Champion Rankings is essentially the statistical version of heroes. The nature of data aggregation itself is to let users know which heroes are the strongest in the current version.
  3. the method of data crawling can circumvent the project itself from obtaining data from op.gg.

diaolingzc avatar Dec 01 '21 01:12 diaolingzc