laravel-country-logomarks
laravel-country-logomarks copied to clipboard
caneco
Wales
Is you request a new country in the list? Not yet!
Your country community links We only have a general PHP community currently (which I organise) but we are full of Laravel Devs!
Additional context We have a dragon on our flag, so feel we represent early Laravel very well
Here's a preview π΄σ §σ ’σ ·σ ¬σ ³σ Ώ
But to be honestβ¦
I don't know how to place the assets folder π€ Should I place it:
-
A) in a
specials/folder -
B) in a new folder
wlsinside the existinguk/folder? -
C) in a new folder
uk-wls
From the 3 options I'm considering either B) or C)β¦
It mainly depends on the convention you are following, from what I can see you are following country codes in an ISO format, I would recommend "CY" as this is the typical language code for Welsh.
https://en.m.wikipedia.org/wiki/Welsh_language
@JustSteveKing I'm trying to keep the ISO 3166-1 ALPHA-2 β¦ but TBH I now see that failed big time with the UK Logomark π
With that in mind, CY should be Cyprus π€
Damn, these things are tricky! Either way, you're doing an awesome job!
You could look at ISO_3166-2 which are country short codes - but then you still hit the UK issue.
Perhaps stick with the pattern you are already following and then: area-country such as uk-cy for Wales and uk-ire for Northern Ireland? Do it which ever way works for you π
@JustSteveKing I'm planing to move the UK folder to GB and use the name "Great Britain" instead of "UK".
Can I have your comments on the PR #27?
β Thanks
That makes perfect sense to me @caneco and I've added a comment on the PR for you. But to log it here also:
I think moving UK to GB makes a lot of sense as it leave you open to expand further should you need to. Also it's a common standard being used, which as someone who loves standards can 100% appreciate!
Thanks for your awesome work as always!
(late response; sorry)
@JustSteveKing thanks for the feedback and validation of the decision π