candy icon indicating copy to clipboard operation
candy copied to clipboard
verified publisher icon candy-chat

Upgrade strophe

Open benlangfeld opened this issue 11 years ago • 8 comments

benlangfeld avatar Apr 15 '15 13:04 benlangfeld

This appears to be broken due to strophe/strophejs#105 introducing AMD in a way that's not backwards-compatible with non-AMD apps like Candy. I'm not sure if that can be fixed in Strophe, or if Candy needs to move to something like require.js. Thoughts @jcbrand / @mweibel?

benlangfeld avatar Apr 15 '15 18:04 benlangfeld

require.js/AMD is not going to happen, it doesn't bring any value (actually quite the opposite, TBH) and becomes soon obsolete due to ES6 (this is my own personal opinion). Why strophe now moves to AMD, I don't know.. Why it doesn't work I don't know either, what is the error you get?

mweibel avatar Apr 15 '15 18:04 mweibel

@mweibel You can see the error in the Travis CI test run. The strange thing is that an app appears functional regardless.

benlangfeld avatar Apr 15 '15 18:04 benlangfeld

@benlangfeld sorry, late reply. Tested it locally as well and it seems to work also. Wondering why it fails.. could it be that we'd need to add Strophe to the loader settings of tests/intern.js?

mweibel avatar Apr 27 '15 05:04 mweibel

I tried that and it didn't make any difference.

benlangfeld avatar Apr 27 '15 10:04 benlangfeld

Sorry, I have some issues with running the tests locally.. that's why it takes so long...

mweibel avatar Apr 30 '15 05:04 mweibel

@benlangfeld the test run on saucelabs, can you give me the URL? I didn't find it on https://saucelabs.com/u/candy-chat-ci somehow :(

mweibel avatar May 05 '15 05:05 mweibel

https://saucelabs.com/users/candy-chat-ci/tests

benlangfeld avatar May 05 '15 12:05 benlangfeld