candy-plugins
candy-plugins copied to clipboard
candy-chat
available-rooms: hardcoded MUC service JID
The MUC service that is searched by available-rooms is hard-coded to 'conference.' + Candy.Core.getConnection().domain, this should be a parameter to the init() function.
In my case, I'm running an anonymous login on 'anon.yax.im' and the MUC service domain is 'chat.yax.im', so it would be great to have support for that.
Also, the documentation does not state if the init() function should be called before or after the Candy.init. I tried both (after hardcoding the MUC service JID), and neither worked :-(
P.S: the createroom plugin has a subdomain option that is also based on the connection domain, making it impossible to use chat.yax.im from anon.yax.im.
@ge0rg take a look here: https://github.com/smokku/candy-plugins/commit/dc0bfe06a6d283f09d649a739369201fe29923ce
You've already done the work to produce the diff, but you don't want to take literally 1 minute to contribute? That's a rather selfish attitude to take to open source, I must say.
Read your Contributing guidelines and think about that 1 minute again.
I already published the diff and took time to point your users to it. If that is selfish...
Our contributing guidelines are perfectly reasonable, @smokku. They're incredibly liberal; we even offer a commit bit: https://github.com/candy-chat/candy-plugins#contributing
It's unfortunate that you believe it's reasonable to make use of the work done by contributors to this project, but object on unknown grounds to making a small contribution yourself. That's not how open source is supposed to work.
I am sorry I took time to contribute to your project. I will stop now and won't bother you again.
The negative side of a liberal license like MIT is that @smokku is perfectly within his rights to behave like this. I'm not sure where the dismissive attitude comes from. I do hope, though, that he'll take a look at the value he gets from projects like this and at some point reflect on his attitude towards those projects, and maybe take 30 seconds from his very busy schedule to try and properly distribute his changes upstream to pay it forward.