wip: Remove deprecated commands

[Glutexo]

Only keep it as systempurpose subcommand.

CCT-402

[Glutexo]

@jirihnidek The AddonsCommand class in addons.py is imported as a subcommand in syspurpose.py.

[Glutexo]

test_addons.py needs to be kept too. The command is still there, just not as a first-class command, but rather as a syspurpose command’s subcommand. The test doesn’t verify the actual CLI syntax, but rather the already invoked command.

[Glutexo]

Or maybe not. 🤔 This line looks suspicious:

https://github.com/candlepin/subscription-manager/blob/dd68e24b5e28bc6469aea87e101422a55edbfb5f/test/cli_command/test_addons.py#L32

But the tests pass even though I removed the command from managercli.

[Glutexo]

It works regardless of the argv value… 🤷🏻‍♂️

[Glutexo]

I think I found all the places where the addons command needs to be removed. I‘ll do the same for the other commands moved under the syspurpose subcommand.

@jirihnidek Do you think it’s ok this way? Didn’t I forget anything?

[Glutexo]

Interesting. In test_role.py, the setUp method doesn’t contain the argv patch present in test_addons.py. test_addons.py however works without the path just fine…

[ptoscano]

This will break the cockpit tests, which currently still use the old commands. I just created a PR to change those: https://github.com/candlepin/subscription-manager-cockpit/pull/69

This PR will need to wait until that is merged.

(also, is it still "wip"?)

[Glutexo]

Fine-tuned the pull request, so it can be reviewed and merged: