subscription-manager icon indicating copy to clipboard operation
subscription-manager copied to clipboard

feat: Removed attach command

Open jirihnidek opened this issue 1 year ago • 2 comments

  • Card ID: CCT-425

Attach command

  • Removed attach command
  • Removed --auto-attach and --autosubscribe CLI options of register command
  • Removed --servicelevel CLI option of register command too, because this CLI option was possible to use only with --auto-attach CLI option. Thus, it does not make sense to keep this option
  • Removed unit tests for attach command
  • Modified unit tests for register command. Only SCA mode is considered.
  • Modified man pages

D-Bus

  • Removed interface: com.redhat.RHSM1.Attach
  • Removed AutoAttach and PoolAttach
  • Modified Register method
  • Removed unit tests related to removed methods
  • Modified unit tests of register D-Bus methods

Attach service

  • Removed attach service
  • Removed unit tests related to attach service

jirihnidek avatar Jun 03 '24 12:06 jirihnidek

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
__init__.py00100% 
rhsmlib/dbus/objects
   __init__.py80100% 
   register.py2016269%35, 88–89, 102–103, 113–114, 116–117, 127–128, 130, 144, 147, 160, 163, 202, 211, 249–250, 257, 275, 283, 286, 329–331, 333–334, 353–356, 358–360, 362, 364, 366, 381, 385, 402–407, 409–411, 413, 415, 427–431, 433–435, 437, 439
subscription_manager
   managercli.py481275%22, 80–82, 84, 86–91, 95
subscription_manager/cli_command
   cli.py2062886%64, 68, 124, 181, 185, 187, 230, 269, 280–282, 296–298, 321, 341, 367, 376–377, 381–382, 398, 400–401, 403–404, 409, 417
   register.py2044577%120, 122, 165–167, 169–170, 173, 184, 188, 195–198, 202–203, 207–208, 219, 247, 251–253, 262, 266, 292, 308–309, 345, 374, 382, 397–399, 408, 439, 449–450, 457–458, 463–467
subscription_manager/scripts
   rhsm_service.py15150%17, 19–20, 23, 26–28, 31–33, 43–45, 48–49
TOTAL18014453874% 

Tests Skipped Failures Errors Time
2534 14 :zzz: 0 :x: 0 :fire: 34.229s :stopwatch:

github-actions[bot] avatar Jun 03 '24 12:06 github-actions[bot]

This must not be merged before https://github.com/candlepin/subscription-manager-cockpit/pull/68 is merged, otherwise the cockpit tests will fail (like they currently do).

ptoscano avatar Jun 27 '24 06:06 ptoscano