subscription-manager icon indicating copy to clipboard operation
subscription-manager copied to clipboard

Handle URL params for AptRepoFiles

Open hstct opened this issue 2 years ago • 5 comments

This change to subscription-manager handles parameters in the URL and thus giving us more options for handling different cases rather than set the values explicitly.

It is part of a change we are currently working on in Katello to replace Simple Publisher with Structured Publisher for Debian based repositories.

ref: https://projects.theforeman.org/issues/35959, https://github.com/Katello/katello/pull/10420

hstct avatar Mar 07 '23 08:03 hstct

cc: @sbernhard

hstct avatar Mar 07 '23 08:03 hstct

Hello :wave: I know it's still a draft, please take a look at the unit test failures (see the pytest jobs).

ptoscano avatar Mar 07 '23 10:03 ptoscano

Hi :) The unit tests should be fixed now.

hstct avatar Mar 07 '23 13:03 hstct

This PR is ready. It improves the usage of debian repositories a lot because features like Apt-Pinning can be used. It requires https://github.com/Katello/katello/pull/10420 which we want to integrate in Katello soon. If everything is ready, we would of course ship now sub-man at https://apt.atix.de :)

sbernhard avatar Mar 28 '23 15:03 sbernhard

It requires Katello/katello#10420 which we want to integrate in Katello soon.

Since that PR still needs to be reviewed and eventually merged, accepting this right now would not be wise (the actual implementation required might change depending on the outcome of the katello PR).

Hence, switching this back to draft until the katello PR is merged.

ptoscano avatar Apr 03 '23 06:04 ptoscano