faster-image icon indicating copy to clipboard operation
faster-image copied to clipboard

resizeMode has no effect on base64Placeholder

Open vyobukhov opened this issue 1 year ago • 2 comments

Hi guys,

I've encountered a bug that appears to have been previously reported by @StasKovalov in the comments of another issue. However, it seems that it might have been overlooked and not addressed yet.

resizeMode has no effect on base64Placeholder. It just stretches it randomly.

Here is the link to the relevant comment for your reference: https://github.com/candlefinance/faster-image/issues/41#issuecomment-2178418843_

vyobukhov avatar Nov 07 '24 18:11 vyobukhov

Should be an easy fix by applying the resize mode here: https://github.com/candlefinance/faster-image/blob/e6f13256b4db961e29786edcac53f508848b7660/ios/FasterImageViewManager.swift#L359.

I don't have the bandwidth to take this on atm, but if you make a PR, I'll merge it!

gtokman avatar Nov 24 '24 13:11 gtokman

bandwidth

Have you merged this fix yet?

ivansmb11 avatar Jan 17 '25 17:01 ivansmb11