Duane Johnson

Results 129 comments of Duane Johnson

We encountered this today as well. If you switch rooms (join + leave) 10 or more times, this event emitter leak warning appears in the console. I believe the issue...

> For anyone interested in using importmaps with Vite right now, you can with workaround. When es-module-shims polyfill is used with `type="importmap-shim"` and `type="module-shim"`, all the imports will be handled...

Tested with latest `main` branch and getting the same behavior.

Is this something that would be a "good first issue"? I've had to put material-shell away for a while in hopes this would be fixed, but maybe I can help?

It was more of a warning than a problem: ![image](https://user-images.githubusercontent.com/129/210091516-b604d7e6-e8c0-4918-8117-c16a13ca4ee7.png)

Yes, I'm using the Flatpak version. Thanks for pointing out a workaround!

I don't mind the existing behavior, especially with the `$key` and `$ref` variants (`crank-key` and `crank-ref` seem a bit lengthy). It adds clarity IMO that these props are different, and...

Personally, I would use two sets like so (since we already have $-prefixed props): - keep $key, $ref: assign the key and ref, but do not pass as props -...

It seems good to lean towards giving more power to the app developer unless there are good reasons not to. As you've mentioned, `key` seems like a clear winner here--I...