camunda-modeler icon indicating copy to clipboard operation
camunda-modeler copied to clipboard

Add OAuth scope field to deploy modal

Open wollefitz opened this issue 1 year ago • 7 comments

Related to https://github.com/camunda/product-hub/issues/2089.

Problem you would like to solve

As a user, I want to be able to deploy to Zeebe clusters that use OAuth2 as authentication mechanism with a provider that requires a scope in the token request, e.g. Microsoft Entra ID.

Proposed solution

Add a field "Scope" (or better "OAuth Scope" and rename "Audience" to "OAuth Audience") to the deploy modal which gets picked up by the Zeebe client for acquiring a token.

Alternatives considered

None

Additional context

  • Web Modeler is also missing the field, see https://github.com/camunda/web-modeler/issues/8027
  • https://github.com/camunda-community-hub/zeebe-client-node-js has to provide support for passing a scope within the token request, see https://github.com/camunda-community-hub/camunda-8-js-sdk/issues/21
  • reported via Slack

wollefitz avatar Feb 05 '24 21:02 wollefitz

We'd need zeebe-node to support passing a custom scope within the token request and this seems to be not implemented (yet). So as it stands we're currently blocked by upstream here I believe?

Shall I create an upstream issue @jwulf?

nikku avatar Feb 06 '24 09:02 nikku

@wollefitz Thanks for opening this issue! I buy into both the enhancement + proposed renaming.

nikku avatar Feb 06 '24 09:02 nikku

Shall I create an upstream issue @jwulf?

@nikku There's already https://github.com/camunda-community-hub/camunda-8-js-sdk/issues/21 (linked below "Additional Contect") created by Josh.

wollefitz avatar Feb 06 '24 09:02 wollefitz

Thanks @wollefitz. I'm a little bit confused as I don't care about camunda-8-js-sdk. We use the zeebe-node client and have not immediate intention to move to something else, unless explicitly required to do so.

nikku avatar Feb 06 '24 09:02 nikku

@nikku - with the 8.5.0 release we will be supporting the JS SDK.

The Zeebe Node client published as zeebe-node is going to be unmaintained from 8.5.0.

The new package will be @camunda8/zeebe. It’s the same code base, but moved to the camunda-8-js-sdk monorepo.

jwulf avatar Feb 07 '24 01:02 jwulf

Thanks for the heads-up @jwulf.

nikku avatar Feb 07 '24 08:02 nikku

Created https://github.com/camunda/camunda-modeler/issues/4109 from our end. Would be great to get a heads-up when @camunda8/zeebe is ready to be migrated to.

It would help us if we'd get scope support in one way or the other, so we can integrate it into the modeler.

nikku avatar Feb 07 '24 08:02 nikku

Waiting for upstream https://github.com/camunda-community-hub/zeebe-client-node-js/pull/363 to be merged and released.

nikku avatar Feb 29 '24 15:02 nikku

Continuing to integrate this via https://github.com/camunda/camunda-modeler/pull/4169.

nikku avatar Mar 01 '24 13:03 nikku

This will be released with the next Desktop Modeler release (v5.21.0).

nikku avatar Mar 04 '24 09:03 nikku