camunda-modeler icon indicating copy to clipboard operation
camunda-modeler copied to clipboard

Modeler 5.0 doesn't show multi-line fields for scripts anymore

Open michaelarnauts opened this issue 2 years ago • 10 comments

Describe the bug

The rework of the property panels in 5.0 doesn't support multi-line property fields anymore. This is needed when writing a script to be executed by a script worker (on Camunda Platform 8), or when working with JSON values.

Steps to reproduce

  1. Add a script task.
  2. Give it type script so it can be picked up by https://github.com/camunda-community-hub/zeebe-script-worker for example.
  3. Add a header language = javascript.
  4. Add a header script and try to add a script there. There is only room for one line.

image

image

Expected behavior

It should be possible to expand the input field so it can contain multi-line values. This is how it worked in Modeler 4.x and earlier.

Environment

  • OS: Ubuntu 22.04
  • Camunda Modeler Version: 5.0
  • Execution Platform: N/A (happens with Camunda Platform 7 and 8 BPMN files)
  • Installed plug-ins: N/A

Additional context

No response

michaelarnauts avatar Jun 01 '22 14:06 michaelarnauts

Thanks for your request!

The rework of the property panels in 5.0 doesn't support multi-line property fields anymore

The properties panel still supports multi line fields, for example Camunda Forms configuration

image

Headers are one-line inputs, that was already the case in Camunda Modeler 4.x

image

I think this is intended, as the docs don't describe the option for multi-line values.

If you think this would be a valuable addition, let's make this one a feature request and discuss it 👍

/cc @christian-konrad

pinussilvestrus avatar Jun 02 '22 06:06 pinussilvestrus

@michaelarnauts What is your use case of adding a script to the header?

christian-konrad avatar Jun 03 '22 09:06 christian-konrad

It seems to be the way how it's implemented in https://github.com/camunda-community-hub/zeebe-script-worker

Also, there is no other field available in models for Camunda 8.

michaelarnauts avatar Jun 03 '22 10:06 michaelarnauts

I have the same problem with editing names of elements изображение

irlaer avatar Jun 09 '22 12:06 irlaer

@irlaer , I believe this is a slightly different issue (name vs. script fields). I created https://github.com/bpmn-io/bpmn-js-properties-panel/issues/705 to track the Name issue

marstamm avatar Jun 13 '22 12:06 marstamm

I think this is something we want to have (again), some day. Moving to backlog.

nikku avatar Jul 11 '22 06:07 nikku

CC @christian-konrad

nikku avatar Jul 11 '22 06:07 nikku

Improved upstream via https://github.com/bpmn-io/bpmn-js-properties-panel/issues/705.

nikku avatar Feb 03 '23 09:02 nikku

Fixed upstream via bpmn-io/bpmn-js-properties-panel#705.

Only for name field, not for the headers or field injections.

michaelarnauts avatar Feb 03 '23 13:02 michaelarnauts

Thanks @michaelarnauts.

Removed fixed upstream. Would be a good candidate to now clean this up end-to-end. We have all foundations in place.

nikku avatar Feb 03 '23 13:02 nikku