camunda-modeler icon indicating copy to clipboard operation
camunda-modeler copied to clipboard

File Name Duplicated When File with Same Name Exists on Disc

Open philippfromme opened this issue 2 years ago • 4 comments

Describe the Bug

When creating a new file the file name is diagram-1.bpmn, diagram-2.bpmn and so on. If a file with one of those names already exists on disc the file name can be duplicated.

fQx8JWauE4

Steps to Reproduce

  1. Create a new file
  2. Save new file on disc using default name
  3. Close modeler
  4. Open modeler
  5. Create new file
  6. New file also has name diagram-1.bpmn

Expected Behavior

No name duplication.

Environment

  • Camunda Modeler Version: 5.0.0

philippfromme avatar Apr 28 '22 06:04 philippfromme

Is that a bug? I'd rather call this a simple enough, no magic behavior. And how crucial is that? Moving to spring cleaning. If it is easy to fix, why not, if not, lets close it again.

nikku avatar Apr 28 '22 07:04 nikku

Like @nikku, I'd argue that this is expected default behavior. An application creates a new file with a default name (like "Untitled Document") and this name could already exist at the place where it will be stored. The system save dialog detects the conflict and handles the case.

andreasgeier avatar Apr 28 '22 10:04 andreasgeier

It's a good hint to rename the file to the real name if the OS mentions that the diagram-1.bpmn already exists.

ingorichtsmeier avatar Apr 28 '22 15:04 ingorichtsmeier

It's a good hint to rename the file to the real name if the OS mentions that the diagram-1.bpmn already exists.

Can you explain what your expected behavior is, please?

The current behavior is the standard approach, I believe. See recording.

https://user-images.githubusercontent.com/938244/167113153-65dde0ab-77dc-4dff-8b33-e7307814e08e.mov

andreasgeier avatar May 06 '22 10:05 andreasgeier