camunda-external-task-client-js icon indicating copy to clipboard operation
camunda-external-task-client-js copied to clipboard

Published 20 hours ago • verified publisher icon camunda

Changed the check for content-type json to allow for charsets to be s…

Open bkwint opened this issue 2 years ago • 4 comments

Current code does not allow for proper header settings in the Content-Type. If Content-Type is set to "application/json; charset=utf-8" the task will not be properly forwarded to the handler callback. By changing the code to only check the start o the Content-Type we accept any charsets that are send.

bkwint avatar Apr 18 '22 12:04 bkwint

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 18 '22 12:04 CLAassistant

Hi @bkwint,

Thank you for raising this PR. We will review it soon and provide you with feedback.

@tasso94 or @danielkelemen, can you take over this review?

Best, Nikola

koevskinikola avatar Apr 22 '22 13:04 koevskinikola

@danielkelemen, this might be a good chance to get to know the codebase a little better. WDYT?

tasso94 avatar Apr 22 '22 14:04 tasso94

@danielkelemen, this might be a good chance to get to know the codebase a little better. WDYT?

Sure, I can take it over.

danielkelemen avatar Apr 26 '22 08:04 danielkelemen