camunda-bpm-platform
camunda-bpm-platform copied to clipboard
Add message to the HTTL updated popup
Acceptance Criteria
When saving HTTL, there should be a second stage of the dialog that communicates the need to run the batch job
Hints
- There is already logic that handles the success / failure of HTTL update request. The only required change is to remove the behaviour that auto closes the popup. webapps/frontend/ui/cockpit/client/scripts/directives/time-to-live/time-to-live-dialog.js:55 customOnChange();
Parent
https://github.com/camunda/camunda-bpm-platform/issues/4093
Tasklist
### Pull Requests
- [ ] https://github.com/camunda/camunda-bpm-platform-ee/pull/897
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/4114
If the HTTL popup is opened from the cleanup page
it has a customOnChange handler attached. On update HTTL request
success this customOnChange calls updatePage to update the cleanable instances table which moves the pages to loading state closing the popup.
As changing the HTTL should not change the number of cleanable instances I opted to remove the unnecessary page reload.
An other option would be to trigger the customOnChange() on HTTL updated dialog
closed rather then on HTTL update request
success. But removing the code has advantages of:
- Not triggering a reload if not needed is a better UX.
- Simplifies code base by not having undead code .
Tested on camunda-bpm-run-ee-7.21.0-20240306.165719-117
https://www.loom.com/share/36942a4684354105a21569b50cdf74c3?sid=9b5800db-d3aa-405b-9fe8-1d2273f30778