check if works with package private

[vainamonen]

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[vainamonen]

How can I run action (CI task) to check if test still works?

[tmetzke]

Hi @vainamonen,

we don't provide any GitHub actions so far that run a CI suite. We use an internal CI that, for security reasons, only runs on PRs issued by a specific group of contributors.

What you can however do is test your changes locally in the JUnit 5 Extension module.

Regarding your changes: The test classes and methods don't have to be all public (as far as I can tell). However, all test methods that want to make use of the @Deplyoment annotation need to be public, otherwise, BPMN deployments don't work for them.

Hope that helps.

Best, Tobias

[vainamonen]

Looks like the same issue https://forum.camunda.io/t/camunda-7-17-possible-bug-junit5-process-tests-require-public-test-method/38369

Sonar in our projects enforces package private in tests (junit 5). So we have problem now on updating Camunda version.

[tmetzke]

I agree, that also sounds like a bug to me. Would you mind creating a ticket over at our Issue Tracker.? If you like, you can also add it to the forum thread.

[tasso94]

Fixed in #2789.