spring-zeebe
spring-zeebe copied to clipboard
camunda-community-hub
Fixes #796 Adding provision to have a result enricher for workers
We want to do additional processing on the incoming and outgoing variables of the worker before they can go into/come from SaaS. Adding the provision to have a custome result enricher.
As seen in the screenshot, I have already agreed to the CLA but the same is not reflecting here. Not sure why. Any idea?
I think @xomiamoore mentioned that the email address being used for the commit in the PR is different from the one being used to sign the CLA. Could you please verify this?
The commit comes from: https://github.com/hemantvermaa The PR is opened by (and most likely the CLA is signed by): https://github.com/hem-verma
That is weird. Seems like I have two accounts or maybe I had an account but later used google account to login again. But the account which created the PR should take the priority. Right? Any other account should be able to push changes as a contributor to the PR. Do you know how this can be fixed?
@xomiamoore provided this guide: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user
Basically, you could amend and then redo your commit
Thanks I will check. I have the changes ready as suggested by you. But I have question about the Unit test. Could you please indicate/guide how to write that. I am confused because there is no unit test for JobHandlerInvokingSpringBeans. and there are not many tests available in the zeebe-client module.
The unit test should be able to prove that your configuration is applied so that the beans that depend on the new feature are created correctly.
Another thing is that the unit test should assert on the logic your code implements. This is trivial with the current approach, but a strategy for selecting a proper ResultProcessor for a JobWorker should be tested as well.
Also, customization options (like bean overriding) could be tested.
May I ask if there are existing examples in the repo for testing the implementation for ParameterResolverStrategy? It will help me in understanding how much to test for ResultProcessor. I could not find anything in the folder src/test/java/io/camunda/zeebe/spring/client
Closed this PR because of wrong account (mistakenly) being used for commit. Created a new PR with correct account. https://github.com/camunda-community-hub/spring-zeebe/pull/833