pyzeebe icon indicating copy to clipboard operation
pyzeebe copied to clipboard

fix: create_camunda_cloud_channel

Open felicijus opened this issue 1 year ago • 3 comments

Fix create_camunda_cloud_channel, current and deprecated functions.

Changes

  1. audience should be static Camunda Docs audience="zeebe.camunda.io
  2. scope should either be None (Optional parameter), because setting it to the cluster_id also works. Maybe relevant for enterprise user with custom scope configs...
  3. leeway and expire_in i don't really know if there is need for customization. Would not hurt to keep I guess.

#510 Is an import error, where the old create_camunda_cloud_channel function was used. (The old function also needs a static audience)

API Updates

New Features (required)

None

Deprecations (required)

pyzeebe.channel.camunda_cloud_channel.create_camunda_cloud_channel

Enhancements (optional)

Less default parameters.

Checklist

  • [x] Unit tests
  • [ ] Documentation

References (optional)

https://docs.camunda.io/docs/8.5/apis-tools/build-your-own-client/#authentication-via-oauth

Fixes #510

felicijus avatar Oct 10 '24 19:10 felicijus

@dimastbk Do we have the option to create Camunda Cloud (SaaS) integration tests ?

felicijus avatar Oct 10 '24 19:10 felicijus

Pull Request Test Coverage Report for Build 11280788679

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.922%

Totals Coverage Status
Change from base Build 11277676454: 0.0%
Covered Lines: 1102
Relevant Lines: 1137

💛 - Coveralls

coveralls avatar Oct 10 '24 19:10 coveralls

Let's wait for #510 to be resolved. @barthansen

felicijus avatar Oct 10 '24 19:10 felicijus

I don't know, I test on trial cluster

dimastbk avatar Oct 11 '24 10:10 dimastbk