pyzeebe
pyzeebe copied to clipboard
fix: create_camunda_cloud_channel
Fix create_camunda_cloud_channel, current and deprecated functions.
Changes
audienceshould be static Camunda Docsaudience="zeebe.camunda.ioscopeshould either be None (Optional parameter), because setting it to thecluster_idalso works. Maybe relevant for enterprise user with custom scope configs...leewayandexpire_ini don't really know if there is need for customization. Would not hurt to keep I guess.
#510 Is an import error, where the old create_camunda_cloud_channel function was used. (The old function also needs a static audience)
API Updates
New Features (required)
None
Deprecations (required)
pyzeebe.channel.camunda_cloud_channel.create_camunda_cloud_channel
Enhancements (optional)
Less default parameters.
Checklist
- [x] Unit tests
- [ ] Documentation
References (optional)
https://docs.camunda.io/docs/8.5/apis-tools/build-your-own-client/#authentication-via-oauth
Fixes #510
@dimastbk Do we have the option to create Camunda Cloud (SaaS) integration tests ?
Pull Request Test Coverage Report for Build 11280788679
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 96.922%
| Totals | |
|---|---|
| Change from base Build 11277676454: | 0.0% |
| Covered Lines: | 1102 |
| Relevant Lines: | 1137 |
💛 - Coveralls
Let's wait for #510 to be resolved. @barthansen
I don't know, I test on trial cluster