pyzeebe
pyzeebe copied to clipboard
camunda-community-hub
add timeout to ActivateJobs request
add timeout to ActivateJobs request handle ZeebeDeadlineExceeded exception
Changes
- timeout to ActivateJobs request
- handle ZeebeDeadlineExceeded exception
API Updates
New Features (required)
None
Deprecations (required)
None
Enhancements (optional)
fixing the issue describe below: when using Camunda cloud zeebe, polling requests for activateJobs can stuck forever, which leads to inability to consume more tasks
Checklist
- [ ] Unit tests
- [ ] Documentation
References
Fixes #324
Hey @EyalCMX, looks good.
Please rebase from master so that tests can run and we can merge
Hey @EyalCMX, looks good.
Please rebase from master so that tests can run and we can merge
@JonatanMartens done please approve!
Pull Request Test Coverage Report for Build 11057437142
Details
- 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.08%) to 96.535%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pyzeebe/grpc_internals/zeebe_adapter_base.py | 2 | 3 | 66.67% |
| pyzeebe/worker/job_poller.py | 0 | 1 | 0.0% |
| <!-- | Total: | 6 | 8 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| pyzeebe/worker/job_poller.py | 1 | 83.33% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 11056680193: | -0.08% |
| Covered Lines: | 1003 |
| Relevant Lines: | 1039 |
💛 - Coveralls
@EyalCMX the job for format checking fails.
Please format using black: poetry run black ., push the changes and I'll approve
@EyalCMX the job for format checking fails. Please format using black:
poetry run black ., push the changes and I'll approve
@JonatanMartens done please approve!
@EyalCMX @JonatanMartens i'm waiting for this to be merged. Is there a more maintained zeebe python plugin available?
@michaelarnauts i dont think @JonatanMartens maintains this library... and i can't merge it
Hey there @michaelarnauts @EyalCMX -- we're looking for additional maintainers for this project. https://github.com/camunda-community-hub/pyzeebe/issues/381
