camunda-external-task-client-python3 icon indicating copy to clipboard operation
camunda-external-task-client-python3 copied to clipboard

Adding json type to task variables

Open fliot opened this issue 3 years ago • 5 comments

Tiny changes to input/output Json variables.

fliot avatar Oct 20 '21 13:10 fliot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

:x: rutscs
:x: svenrr
:x: yogeshrnaik
:x: fliot


rutscs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 20 '21 13:10 CLAassistant

Removing debug

fliot avatar Oct 20 '21 14:10 fliot

Hi, I must confess I do not understand the branching workflow you are following, Json Task variables is a very interesting feature, why don't you add it into the master branch ? Please, explain us.

fliot avatar Oct 29 '21 16:10 fliot

Hi, I must confess I do not understand the branching workflow you are following, Json Task variables is a very interesting feature, why don't you add it into the master branch ? Please, explain us.

Sorry for the delay. Thank you for the great feature. I have approved the PR. Please fix the failing build/tests before merging.

yogeshrnaik avatar Oct 29 '21 17:10 yogeshrnaik

Hi there @yogeshrnaik! As these commits are from back in late August, they won't count towards the Camunda Hacktoberfest project. Would you be so kind as to remove the 'hacktoberfest-accepted' issue label?

@rutscs if you would be so kind as to sign the CLA, that would be amazing. Thank you both so much! Alternately, @svenrr or @yogeshrnaik can re-run the CLA bot to remove that user from the automated check if they are no longer a contributor to the project.

celanthe avatar Nov 02 '21 21:11 celanthe