methodical icon indicating copy to clipboard operation
methodical copied to clipboard

Clojurescript support

Open darkleaf opened this issue 6 years ago • 5 comments

Hi! Is it planed to implement clojurescript support?

darkleaf avatar Sep 11 '19 12:09 darkleaf

I can remove all type hints, deftype+, defprotocol+ and do other stuff. Yes, it will be slower but we will get cljs support. I don't know how slower it will be. I can run benchmark.

Will you accept this contribution?

darkleaf avatar Sep 11 '19 17:09 darkleaf

Hi @darkleaf, that would definitely be a great contribution, and I'd be happy to accept. I wouldn't worry too much about running benchmarks, but making sure we can run tests with ClojureScript is definitely something we would want to do.

camsaul avatar Sep 11 '19 19:09 camsaul

Would your prefer one big patch or many small patches?

darkleaf avatar Sep 11 '19 20:09 darkleaf

I want to solve own problem. So I've created library https://github.com/darkleaf/multidecorators It's small subset of methodical but with clojurescript support.

If you need help, please contact me.

darkleaf avatar Sep 13 '19 17:09 darkleaf

@camsaul is there any chance you might still be interested as you suggested (https://github.com/camsaul/methodical/pull/25#issuecomment-860108571) in seeing ClojureScript support in the library?

I'd usually offer to contribute and take a stab at this myself, but methodical is a much hairier library than most and no doubt you have a good handle on what it would take to move over, given the above-mentioned issues.

I'd really like to see the library extended to CLJS, so if it's unlikely you'll get a chance to look for a long time yet then I can take a stab, but I just thought I'd check in first.

Thanks so much for the amazing library!

tekacs avatar Jan 08 '22 06:01 tekacs