humane-are
humane-are copied to clipboard
`humane-are.core-test` suggestions
Hi! Great-looking lib, I'm a heavy arer myself.
A couple suggestions for increasing my confidence in it:
- In
t/deftest are-test, you can also assert(is (= x (macroexpand ,,,)))i.e. set expectations for what the macroexpansions should be - You can assert that no false positives are raised
- placing
issomewhere deeply nested (vs. top-level) is ok. - top-level
testingis OK if it has atrueat tail position.- this is a pattern that clj-kondo and Eastwood understand.
- this allows for custom
testingstrings that are not simply the arguments already provided byare+
- placing
Hope it helps!
Cheers - V
@vemv those are great ideas, any interest in submitting a PR?
I lack the bandwidth these days, sorry!