humane-are icon indicating copy to clipboard operation
humane-are copied to clipboard

`humane-are.core-test` suggestions

Open vemv opened this issue 3 years ago • 2 comments

Hi! Great-looking lib, I'm a heavy arer myself.

A couple suggestions for increasing my confidence in it:

  • In t/deftest are-test, you can also assert (is (= x (macroexpand ,,,))) i.e. set expectations for what the macroexpansions should be
  • You can assert that no false positives are raised
    • placing is somewhere deeply nested (vs. top-level) is ok.
    • top-level testing is OK if it has a true at tail position.
      • this is a pattern that clj-kondo and Eastwood understand.
      • this allows for custom testing strings that are not simply the arguments already provided by are+

Hope it helps!

Cheers - V

vemv avatar Sep 02 '22 09:09 vemv

@vemv those are great ideas, any interest in submitting a PR?

camsaul avatar Sep 02 '22 15:09 camsaul

I lack the bandwidth these days, sorry!

vemv avatar Sep 02 '22 15:09 vemv