cgxp icon indicating copy to clipboard operation
cgxp copied to clipboard

Published 20 hours ago • verified publisher icon camptocamp

Disclaimer appear even if the layer is not checked

Open rbovard opened this issue 11 years ago • 5 comments

Is it an intended behaviour that the Disclaimer appear even if the layer is not checked?

It seems it depends of the presence of the group where the layer is and not of the status of the layer itself.

rbovard avatar Oct 11 '13 06:10 rbovard

Have you an URL and an example ?

sbrunner avatar Oct 11 '13 17:10 sbrunner

Yes, here : (link removed)

The disclaimer is defined for the layer "Arrêts de bus"

rbovard avatar Oct 14 '13 07:10 rbovard

Hello that's the expected behaviour: the disclaimer panels are displayed (only) the first time the matching layers are added to the layers list whatever they are checked or not. See https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/Disclaimer.js#L123 The modal disclaimer plugin works the same way.

asaunier avatar Oct 15 '13 10:10 asaunier

Ok, thank you for the precision. That was my question.

I wonder if it would not be better to display the disclaimer on the first display of the layer?

rbovard avatar Oct 16 '13 06:10 rbovard

I wonder if it would not be better to display the disclaimer on the first display of the layer?

Maybe. I guess the current behaviour was the one initally wished when the plugin was developed. I guess changing to the behaviour you described would be quite a big change.

asaunier avatar Oct 23 '13 13:10 asaunier