go-tooling-workshop icon indicating copy to clipboard operation
go-tooling-workshop copied to clipboard

Fill the docker section

Open nhurel opened this issue 7 years ago • 5 comments

Proposal for your issue #5

nhurel avatar Aug 04 '17 11:08 nhurel

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Aug 04 '17 11:08 googlebot

I signed it!

nhurel avatar Aug 04 '17 11:08 nhurel

CLAs look good, thanks!

googlebot avatar Aug 04 '17 11:08 googlebot

I've integrated part or your remarks. I don't fully understand what you expect from the Cross building binary section, I let you read my comments.

nhurel avatar Aug 11 '17 16:08 nhurel

Hey, I just came back from holidays and I'll be reviewing this in a couple days. Thanks so much!

campoy avatar Aug 23 '17 22:08 campoy