aws-cloudwatch-statsd-backend
aws-cloudwatch-statsd-backend copied to clipboard
Support for Cloudwatch dimensions
I missed the ability of using Cloudwatch dimensions. With the changes, dimensions can be specified in the configuration file, i.e.:
cloudwatch: { accessKeyId: 'xxx', secretAccessKey: 'yyy', region:"US_EAST_1", processKeyForNamespace: true, dimensions:[ { "Name": "Instance", "Value": "i-2bc24da" } ] }
Dimensions can also be specified in the statistic name:
Namespace.__dimension1_value1.__dimension2_value2.latency:300|ms
Additionally, a string may be provided to the "processKeyForNamespace" option, so instead of splitting the stat name as usual, the provided string will be used for building another regexp that will be used for splitting.
I do beg your pardon, I've completely missed this pull request! I agree, dimensions are a priority. I'm just not sure the format is ideal. Also I'm sure your code could be clearer. I'll take a look at it soon.
@camitz hi, do you plans to merge this pr?
At the moment there are conflicts with some recent pulls. Also I'm not confortable with the suggested string format. I would prefer being able to do this:
App.Controller.Action.Request.donuts:sprinkled.carpet:striped:1|c
Thank you for the interest in this PR. @camitz 's concerns are very valid. However, unfortunately, I am not planning to put any time on this for the time being.
@camitz @tuxpiper i can look and refresh this PR a bit if you both agree.
You have my sincerest blessing!
Absolutely @jotes , go forth!