Cameron Fairchild comments

Results 44 comments of


                                            Cameron Fairchild

Importing metadata without signature

I think a better solution is allow adding multiple signers for a single chain. This would allow using whichever metadata portal is updated first. Currently you must remove the network,...

Support transaction signing without metadata

This is akin to blind-signing. I'm not sure this should be supported because I could see a user always using blind-signing, and not truly understanding the implications.

add cleared amount in remove_stake

Please rebase this on devnet_ready

Reimplement StakeDelta

> why? Prevents consensus issues with large stake movements between hotkeys

Have SubtensorModule::TotalIssuance track extrinsic fees

> It does handle transaction fees: > > https://github.com/opentensor/subtensor/blob/0b2f65c1f8f5e69fc01d2eae37630e50278dc7ac/runtime/src/lib.rs#L394-L409 > > This rounding issue is tiny (~20 rao) due to floating point arithmetic issues. does this hook on account kill...

Fixed a bug in the get_subnets function

Thanks for the contribution! How was this fix tested? The issue can be reproduced on the testnet and I don't believe this fixes it. See example: ```python import bittensor subtensor...

Disable trading-type extrinsic for new subnet until start call

> The extrinsic list as follows: > > 1. group one: filter according to netuid as method parameter > add_stake > remove_stake > burned_register > recycle_alpha > burn_alpha > >...

rework for pure proxy evm

> just remembered why I design the solution like this way. > > 1. extra map. for js application, it can get the event and get which proxy account created....

Do not throw on wrong password input

Black check isn't passing on CI

Set Children: No check for empty vector

We do need to support setting it to empty. Just make sure to `::remove` I guess