celery-once icon indicating copy to clipboard operation
celery-once copied to clipboard

Ignore FileNotFoundError when removing the lock file

Open xuhcc opened this issue 5 years ago • 4 comments

Related issue: #115

xuhcc avatar Feb 19 '20 13:02 xuhcc

@xuhcc Thanks for the quick PR on this. My only concern is that we are silently suppressing this. I wonder if it's worth adding a warning or log of some sort to indicate the lock was removed prematurely? Else, users who encounter this will most likely just assume the lock isn't working. Any thoughts?

cameronmaske avatar Feb 20 '20 09:02 cameronmaske

I agree that some kind of warning certainly would be useful in this case, but I'm not sure how to implement it. It seems that celery-once doesn't currently employ the logging module.

xuhcc avatar Feb 21 '20 09:02 xuhcc

@xuhcc Yeh, fair point. Adding logging is a whole separate improvement and can be tackled later.

cameronmaske avatar Mar 25 '20 13:03 cameronmaske

Hello, do you know how much "later" it will be to merge & release this? It's nearly 2 years later but I'm getting the same traceback as described in #115 with version 3.0.1

eyeteajay avatar Apr 15 '24 22:04 eyeteajay