concurrentqueue icon indicating copy to clipboard operation
concurrentqueue copied to clipboard

Consider not making functions in headers static to improve compatibility with C++ modules

Open jcelerier opened this issue 1 year ago • 1 comments

If a function is marked static, the header put into the global fragment and a template ends up causing instantiation and thus call of this static function, well, with modules this does not work.

Here's a patch : https://github.com/cameron314/concurrentqueue/commit/324c8187e294a78618c99d19dd7cd43809784333

jcelerier avatar Nov 02 '24 23:11 jcelerier

Seems reasonable. Please open a PR with that diff.

cameron314 avatar Nov 08 '24 21:11 cameron314