nostream icon indicating copy to clipboard operation
nostream copied to clipboard

Dynamic Configs

Open antonleviathan opened this issue 2 years ago • 2 comments

Description

Refactor to use a mix of file and db stored config values

Related Issue

https://github.com/Cameri/nostream/issues/197

Motivation and Context

This will make it easier to manage, specifically update, config values,

How Has This Been Tested?

TODO

Types of changes

  • [ ] Non-functional change (docs, style, minor refactor)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my code changes.
  • [ ] All new and existing tests passed.

antonleviathan avatar Feb 12 '23 07:02 antonleviathan

Pull Request Test Coverage Report for Build 4184263694

  • 1 of 20 (5.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 58.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/repositories/config-repository.ts 0 19 0.0%
<!-- Total: 1 20
Files with Coverage Reduction New Missed Lines %
src/handlers/request-handlers/root-request-handler.ts 9 13.79%
<!-- Total: 9
Totals Coverage Status
Change from base Build 4148256062: -0.4%
Covered Lines: 1168
Relevant Lines: 1971

💛 - Coveralls

coveralls avatar Feb 12 '23 07:02 coveralls