nostream
nostream copied to clipboard
fix: SettingsStatic class default to yaml file
Description
This patch fixes scenarios where the user renamed the settings file to settings.json.<something> which caused the settings setup script to concatenate the settings name incorrectly
Related Issue
N/A
Motivation and Context
Fixes a bug
How Has This Been Tested?
Local reproduction of issue
Screenshots (if appropriate):
Types of changes
Update of a method, no backward compatiblity implications
Checklist:
- [x] My code follows the code style of this project.
- [] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my code changes.
- [x] All new and existing tests passed.
Pull Request Test Coverage Report for Build 4080304677
- -3 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
- 104 unchanged lines in 12 files lost coverage.
- Overall coverage decreased (-5.9%) to 53.741%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/utils/settings.ts | 0 | 3 | 0.0% |
| <!-- | Total: | 0 | 3 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/repositories/event-repository.ts | 1 | 97.44% |
| src/handlers/event-strategies/replaceable-event-strategy.ts | 2 | 84.62% |
| src/adapters/web-server-adapter.ts | 3 | 56.67% |
| src/handlers/event-message-handler.ts | 3 | 85.28% |
| src/factories/rate-limiter-factory.ts | 4 | 45.45% |
| src/app/worker.ts | 5 | 34.29% |
| src/cache/client.ts | 5 | 40.0% |
| src/adapters/redis-adapter.ts | 6 | 6.38% |
| src/handlers/request-handlers/rate-limiter-middleware.ts | 8 | 17.5% |
| src/utils/settings.ts | 10 | 65.82% |
| <!-- | Total: | 104 |
| Totals | |
|---|---|
| Change from base Build 4077310695: | -5.9% |
| Covered Lines: | 1027 |
| Relevant Lines: | 1871 |
💛 - Coveralls
Pull Request Test Coverage Report for Build 4095053537
- 1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
- 90 unchanged lines in 11 files lost coverage.
- Overall coverage decreased (-0.7%) to 58.999%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/app/app.ts | 0 | 1 | 0.0% |
| src/utils/settings.ts | 1 | 3 | 33.33% |
| <!-- | Total: | 1 | 4 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/repositories/event-repository.ts | 1 | 98.72% |
| src/routes/invoices/index.ts | 1 | 80.0% |
| src/app/worker.ts | 2 | 51.43% |
| src/factories/worker-factory.ts | 2 | 90.32% |
| src/utils/settings.ts | 7 | 72.15% |
| src/controllers/callbacks/zebedee-callback-controller.ts | 8 | 16.13% |
| src/adapters/web-socket-server-adapter.ts | 9 | 74.63% |
| src/handlers/event-message-handler.ts | 12 | 86.59% |
| src/app/app.ts | 15 | 16.0% |
| src/adapters/web-socket-adapter.ts | 16 | 56.67% |
| <!-- | Total: | 90 |
| Totals | |
|---|---|
| Change from base Build 4077310695: | -0.7% |
| Covered Lines: | 1167 |
| Relevant Lines: | 1951 |
💛 - Coveralls
:tada: This PR is included in version 1.22.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:







