Noah Lev

Labels aren't applied when merge conflicts occur

5

I think bors is supposed to apply `S-waiting-on-author` and remove `S-waiting-on-review` when merge conflicts occur, but it hasn't been happening recently. See some examples [here](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20not.20applying.20labels.20on.20merge.20conflicts).

`cfg(bootstrap)` docs don't say what it does

1

https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#why-does-only-libstd-use-cfgbootstrap cc https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/rename.20.60cfg.28bootstrap.29.60.20to.20.60cfg.28stageN.29.60

Tracking issue for "Compiler walkthrough" section

6

(name is to-be-bikeshedded) cc https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/planning.20meeting.202021.2E02.2E18 ----- - [ ] Implement integer32llc/rust-playground#502 [@jyn514] - [ ] **AST**: https://github.com/integer32llc/rust-playground/pull/722 - [x] **HIR**: https://github.com/integer32llc/rust-playground/pull/683 - [x] Implement `-Z unpretty={ast-tree,thir-tree}` [@LeSeulArtichaut] - [x] **AST:**...

See https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/binder.20refactor/near/233042116.

I used to use the "open a rust-lang/rust issue" link a lot to be able to quickly copy pre-formatted example code, a playground link, and stdout, but that feature was...

Syntax-highlight emitted MIR as Rust

3

This would make it much easier to read the output since MIR is syntactically very similar to Rust.

Prefer Google Fonts version of Source Code Pro over local version

2

There are issues with some versions of Source Code Pro that prevent changing the color of the font from black (e.g., syntax highlighting doesn't work). Firefox 80 seems to have...

Panic with "Cannot replace slice of data that was already replaced"

6

I have a PR to add a new suggestion to rustc: https://github.com/rust-lang/rust/pull/88672. It uses [`Diagnostic::multipart_suggestions`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/diagnostic/struct.Diagnostic.html#method.multipart_suggestions) since there are multiple ways for the user to change their code. These multiple suggestions...

I find that the new(ish) table in performance summaries, while theoretically helpful, is overwhelming to look at. It gives me a lot of detail, but I have trouble finding the...

rust-timer contradicts itself about whether there were perf changes

3

Example: https://github.com/rust-lang/rust/pull/90411#issuecomment-955130324 rust-timer says both: > This benchmark run did not return any relevant changes. and: > While you can manually mark this PR as fit for rollup, we strongly...