feat: Store message db
Description
Describe your changes in detail.
Motivation and Context
close #755
- [ ] I have raised an issue to propose this change (required for new features and bug fixes)
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds core functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation (update in the documentation)
- [ ] Example (update in the folder of example)
Implemented Tasks
- [ ] Subtask 1
- [ ] Subtask 2
- [ ] Subtask 3
Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!
- [ ] I have read the CONTRIBUTION guide. (required)
- [ ] My change requires a change to the documentation.
- [ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
- [ ] I have updated the documentation accordingly.
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
I am PRO ORM. The benefits of using it are:
- It creates a common framework for developers to follow. For example, database operations for different entities can be neatly encapsulated in their own classes or modules.
- It provides type safety by inferring types from queries, ensuring that developers provide all required data during insertions.
- It reduces boilerplate code.
However, I might be overlooking some Python-specific limitations. Could you please elaborate on why "ORM is not very convenient to use in Python"? Thanks.
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
I am PRO ORM. The benefits of using it are:
- It creates a common framework for developers to follow. For example, database operations for different entities can be neatly encapsulated in their own classes or modules.
- It provides type safety by inferring types from queries, ensuring that developers provide all required data during insertions.
- It reduces boilerplate code.
However, I might be overlooking some Python-specific limitations. Could you please elaborate on why "ORM is not very convenient to use in Python"? Thanks.
I think it is not suitable for complex SQL queries, and for tables with large amounts of data, it will consume more memory.
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
I am PRO ORM. The benefits of using it are:
- It creates a common framework for developers to follow. For example, database operations for different entities can be neatly encapsulated in their own classes or modules.
- It provides type safety by inferring types from queries, ensuring that developers provide all required data during insertions.
- It reduces boilerplate code.
However, I might be overlooking some Python-specific limitations. Could you please elaborate on why "ORM is not very convenient to use in Python"? Thanks.
I think maybe we can talk later with slack, how about this?
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
SQLAlchemy is a popular ORM library for Python, but I never used it before, maybe we can take a look at this
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
I noticed the plain SQL statements embedded in the read/write methods and was wondering if the use of an ORM was ever discussed
no, IMO, because ORM is not very convenient to use in Python.
I am PRO ORM. The benefits of using it are:
- It creates a common framework for developers to follow. For example, database operations for different entities can be neatly encapsulated in their own classes or modules.
- It provides type safety by inferring types from queries, ensuring that developers provide all required data during insertions.
- It reduces boilerplate code.
However, I might be overlooking some Python-specific limitations. Could you please elaborate on why "ORM is not very convenient to use in Python"? Thanks.
Thanks @Huang-yi-3456 @sfc-gh-yihuang-2 , are you in our slack channel? Can you reach out to @raywhoelse (id: ray) or me (id: Wendong Fan) to arrange a meeting together to discuss about the detail?