camel icon indicating copy to clipboard operation
camel copied to clipboard

feat: add duckduckgo search and enhance the text extraction from the website

Open jjyaoao opened this issue 1 year ago • 5 comments

Description

Add duckduckgo search and enhance the text extraction from the website.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

  • [x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds core functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (update in the documentation)
  • [ ] Example (update in the folder of example)

Implemented Tasks

  • [ ] Subtask 1
  • [ ] Subtask 2
  • [ ] Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [x] I have read the CONTRIBUTION guide. (required)
  • [ ] My change requires a change to the documentation.
  • [x] I have updated the tests accordingly. (required for a bug fix or a new feature)
  • [ ] I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features

    • Enhanced search capabilities across multiple search engines including Google and DuckDuckGo.
    • Introduced a feature to continue search based on user interactions.
    • Improved text extraction from web pages for more accurate summarization.
  • Documentation

    • Updated documentation for search functionalities.
  • Tests

    • Added tests for the new DuckDuckGo search and summarize functionality.

jjyaoao avatar Jan 24 '24 11:01 jjyaoao

@lightaime @Wendong-Fan @dandansamax Hello. Since I have reviewed and tested the code to add the API of duckduckgo search, if available could you please review the PR, too? thanks.

Appointat avatar Jan 31 '24 14:01 Appointat

@jjyaoao Hi, I found the CI/CD failed, could you please fix it by the way?, and thanks so much. Or, when I am available, I will fix it with you. Thanks : )

Appointat avatar Feb 21 '24 06:02 Appointat

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent update enhances the functionality and documentation of various search-related functions within the project. It introduces a new search function for DuckDuckGo, refines the Google search result structure, and improves text extraction using the newspaper library. Additionally, a continue_search function is added, and the search_and_summarize function is upgraded to support multiple search engines with interactive user logic.

Changes

File(s) Change Summary
.../search_functions.py - Refined search_wiki documentation
- Added search_duckduckgo
- Modified search_google result structure
- Updated text_extract_from_web to use newspaper
- Introduced continue_search
- Enhanced search_and_summarize for multiple search engines
- Added user interaction logic in search_google_and_summarize
test/.../test_search_functions.py - Added test for search_duckduckgo_and_summarize

"In the digital meadows, under the silicon sky,
A code rabbit hopped, with a twinkle in its eye.
🌐🐰 It danced through the code, with a tweak and a fix,
Adding functions and tests, with its magic tricks.
'Let's search the web wide, with engines galore,
DuckDuckGo, Google, and many more!'
Celebrate, dear friends, for our rabbit's quest,
Has made searching the web, simply the best."


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 21 '24 15:02 coderabbitai[bot]

@camel-ai/camel-maintainers Hi, could you please review this PR? This PR has been proposed for several months now, and we've made many modifications; it should be close to merging. thanks.

Appointat avatar Apr 22 '24 13:04 Appointat

Dear @camel-ai/camel-maintainers A kind reminder, we should complete the review of this PR before the end of this sprint, which is in two days.

Wendong-Fan avatar May 05 '24 04:05 Wendong-Fan