camel icon indicating copy to clipboard operation
camel copied to clipboard
verified publisher icon camel-ai

Remove duplicate TODO comment in chat_agent.py#5002

Open shudanluo opened this issue 3 months ago • 3 comments

Summary

Remove duplicate TODO comment that was causing code redundancy.

Changes

  • Removed duplicate "TODO: Handle tool calls" comment on line 1451
  • Kept original TODO on line 1409 for proper issue tracking

Related Issue

Addresses #3002 - Clean CAMEL code base

shudanluo avatar Sep 18 '25 11:09 shudanluo

@nitpicker55555 review

shudanluo avatar Sep 18 '25 11:09 shudanluo

Hi @shudanluo , thanks for your contribution!

However, I noticed that this PR doesn't quite match what the issue is asking for. The issue is about removing outdated features that are no longer needed, but this PR seems to be adding a new LLM-supervised deduplication feature instead.

For cleaning up outdated features, we should be looking at removing things like:

  • MarkItDownToolkit - already deprecated in favor of FileToolkit
  • FileWriteToolkit - deprecated alias for FileToolkit
  • Deprecated math toolkit aliases (add, sub, multiply, divide, round)
  • Deprecated GitHub toolkit methods (old naming without github_ prefix)
  • Deprecated search method (tavily_search → search_tavily)

These are all marked with deprecation warnings and have clear migration paths, making them perfect candidates for removal.

Hi @Wendong-Fan are the deprecated items listed above what you meant by "features that we no longer need"?

nitpicker55555 avatar Sep 18 '25 11:09 nitpicker55555

Hey @shudanluo

Thanks again for contributing to this PR, would love to hear about how progress has been coming along and whether we can help in any way!

waleedalzarooni avatar Nov 04 '25 05:11 waleedalzarooni