camel icon indicating copy to clipboard operation
camel copied to clipboard
verified publisher icon camel-ai

feat: browserToolkit supports async

Open subway-jack opened this issue 9 months ago • 3 comments

Added a BaseBrowser that supports asynchronous

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • [x] I have read the CONTRIBUTION guide (required)
  • [x] I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • [x] I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • [x] I have updated the tests accordingly (required for a bug fix or a new feature)
  • [x] I have updated the documentation if needed:
  • [x] I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

subway-jack avatar Mar 17 '25 04:03 subway-jack

hey @subway-jack , thanks for the contribution! I turned the status of this PR to draft, feel free to open this once it's ready for review~

Wendong-Fan avatar Mar 22 '25 08:03 Wendong-Fan

and can you add some examples and tests by updating example/browser_toolkit.py and test/test_browser_toolkit.py?

fengju0213 avatar Mar 27 '25 09:03 fengju0213

and can you add some examples and tests by updating example/browser_toolkit.py and test/test_browser_toolkit.py?

Thank you for the reminder. Since synchronous and asynchronous tests and examples cannot run in the same script, I’ll create separate files for each.

subway-jack avatar Mar 27 '25 13:03 subway-jack