camel icon indicating copy to clipboard operation
camel copied to clipboard

refactor: video tookit

Open lqjack opened this issue 9 months ago • 5 comments

Description

enhance video toolkit

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • [x] I have read the CONTRIBUTION guide (required)
  • [ ] I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • [ ] I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • [ ] I have updated the tests accordingly (required for a bug fix or a new feature)
  • [ ] I have updated the documentation if needed:
  • [ ] I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

lqjack avatar Mar 14 '25 08:03 lqjack

@lqjack Thanks,At present, only the audio has been segmented, right? Maybe the video needs to be segmented as well

fengju0213 avatar Mar 19 '25 04:03 fengju0213

maybe we can use context manager to manage resources,like files clean

Do you mean if you need to download the video, delete it after analyzing it?

fengju0213 avatar Mar 27 '25 13:03 fengju0213

maybe we can use context manager to manage resources,like files clean

Do you mean if you need to download the video, delete it after analyzing it?

yeah,exactly

zjrwtx avatar Mar 27 '25 13:03 zjrwtx

maybe we can use context manager to manage resources,like files clean

Do you mean if you need to download the video, delete it after analyzing it?

yeah,exactly

but in practice, this is not easy to implement because the "analysis completed" state is difficult to define, and analysis may be performed multiple times during usage.

fengju0213 avatar Mar 27 '25 13:03 fengju0213

maybe we can use context manager to manage resources,like files clean

Do you mean if you need to download the video, delete it after analyzing it?

yeah,exactly

but in practice, this is not easy to implement because the "analysis completed" state is difficult to define, and analysis may be performed multiple times during usage.

oh,i see.thanks

zjrwtx avatar Mar 27 '25 13:03 zjrwtx

@lqjack thanks!

fengju0213 avatar Apr 17 '25 15:04 fengju0213