camel icon indicating copy to clipboard operation
camel copied to clipboard

feat: react agent integration

Open HalberdOfPineapple opened this issue 1 year ago • 3 comments

Description

Basically implemented the agent which outputs in ReAct pattern but only tested on several QA tasks. This PR is mainly for review purposes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

  • [ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds core functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (update in the documentation)
  • [x] Example (update in the folder of example)

Implemented Tasks

  • [ ] Subtask 1
  • [ ] Subtask 2
  • [ ] Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [x] I have read the CONTRIBUTION guide. (required)
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
  • [ ] I have updated the documentation accordingly.

HalberdOfPineapple avatar Jun 22 '23 13:06 HalberdOfPineapple

Overall looks good. Tests must be added.

Thanks very much for these comments. I know there are many problems with this commit and because I spent past several days working on another functionality (OpenAI function calling) I have not updated them on time. I will continue on this following your guidance later :)

HalberdOfPineapple avatar Jul 01 '23 10:07 HalberdOfPineapple

Hi, currently I ran into some problems:

  1. the test cannot be passed because the package langchain is not installed when Github does the check, which leads to failure of examples with Google search included. But I did included langchain in requirements.txt
  2. For integrating Google search, some external API is needed and here I used the wrapper of SerpAPI (the wrapper is implemented by langchain but I can replace the wrapper later). No matter what the wrapper is, the API itself needs an API key. I am wondering whether our group can provide this for search-related functionalities (not necessarily SerpAPI) and integrate the API key in Git checks (without this my implementation cannot pass the tests because it cannot Google search operations when needed) .

HalberdOfPineapple avatar Jul 05 '23 19:07 HalberdOfPineapple

For extra packages, put them in pyproject.toml poetry section.

Obs01ete avatar Jul 06 '23 09:07 Obs01ete

Closed since not active.

lightaime avatar Oct 15 '24 13:10 lightaime