camel icon indicating copy to clipboard operation
camel copied to clipboard

feat: add function call in SGLang

Open NeilJohnson0930 opened this issue 10 months ago • 3 comments

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • [ ] I have read the CONTRIBUTION guide (required)
  • [ ] I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • [ ] I have checked if any dependencies need to be added or updated in pyproject.toml and poetry.lock
  • [ ] I have updated the tests accordingly (required for a bug fix or a new feature)
  • [ ] I have updated the documentation if needed:
  • [ ] I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

NeilJohnson0930 avatar Feb 28 '25 12:02 NeilJohnson0930

thanks, LGTM

mustardBloom avatar Mar 09 '25 12:03 mustardBloom

Hi @zechengz ! Thanks for your comments, I have made targeted fix based on the comments provided above. Feel free to review updated manuscript and let us know if you have any further suggestions.

NeilJohnson0930 avatar Mar 09 '25 14:03 NeilJohnson0930

@NeilJohnson0930 Feel free to merge after resolving the conflicts

zechengz avatar Mar 10 '25 05:03 zechengz