Kamil Śliwak

Results 777 comments of Kamil Śliwak

> I cannot import a Solidity module and emit an event directly from it. This is now fixed: #16336. Will go into the next release. > I can't write a...

Other than this, did you find any other incompatibilities between free functions and libraries? I actually thought there would be more, but the only thing I could come up with...

A related issue is that selectors on constant function pointers are not constant either: ```solidity contract C { C c; function f() external {} function() external varPtr = c.f; function()...

Also note that the `.address` member has a similar issue (https://github.com/argotorg/solidity/issues/16339#issuecomment-3629314230), but again, fixing it would require solving #16339 first.

One of the consequences of functions not being constant is that the `.address` member not a constant either. If we change this for functions, we should change it for this...

> event which is defined in a separated, imported contract. Note that this technically does not have to be a separate file (and it's a file, not a contract). A...

Also, this needs a changelog entry.

Here's the comment I made the last time @matheusaaguiar asked me about this PR. I guess I should have just posted it here. Anyway: > Is this change even correct?...

We already have an old pending PR for this: #15539. We should close one of them.

Here's the comment I made the last time @matheusaaguiar asked me about that other PR. I guess I should have just posted it there. It's also still relevant here: >...