Kamil Śliwak
Kamil Śliwak
You can just dismiss the review :) But in any case, I'm now back from Berlin and catching up so I'm going to go back to this pretty soon.
> Addresses #13497 Does it fix the issue completely?
OK, changed to `Fixes #13497` to have github close it automatically.
It's there but we added it as a dependency very recently so not all of our libs link to it yet. You have to add it to `target_link_libraries` in `libsolutil/CMakeLists.txt`....
This issue solves #13517 as well, right? Should be added to the top comment.
The issue itself is still open and from what I see the objections in the PR were mainly to the way it was implemented so maybe we can find an...
Previous issue about conditionals: #12864. If we're fine with doing it for `if`s, I don't see any reason not to for `try`/`catch` as well.
I think it might be better only to switch between which one is the default depending on the EVM version but still accept both. Otherwise it would be breaking regarding...
@mryalamanchi It would not affect upgrades (i.e. storage layout) at all. The compiler should still produce the same exact bytecode even with the new name. At the EVM level the...
So far the biggest problem seems to be the fact that this would affect portability of third-party libraries. They would no longer be able to provide code that uses `block.difficulty()`...