Footnote icon indicating copy to clipboard operation
Footnote copied to clipboard

Add contributors screen.

Open cambardell opened this issue 4 years ago • 9 comments

Add a contributors screen to the app, with a list of links to the GitHub profiles of each contributor. Bonus points for using GitHub's API to automate.

cambardell avatar Sep 15 '20 13:09 cambardell

I can take care of this

tbraun1551 avatar Sep 29 '20 16:09 tbraun1551

@tbraun1551 Thanks for your interest! Since this is tagged as a good first issue, it's meant for newcomers to either SwiftUI or Open Source development in general. If you fit either of those categories, I'll assign it to you now.

cambardell avatar Sep 29 '20 23:09 cambardell

I definitely am a newcomer to Open source dev in general and am somewhat new to SwiftUI. I think it would be a good challenge for me and help me learn.

tbraun1551 avatar Sep 29 '20 23:09 tbraun1551

Sounds great @tbraun1551, assigned to you.

cambardell avatar Sep 29 '20 23:09 cambardell

I am almost done with the Contributor screen view, and am just working on trying to figure out a way to automate it.

I am using the Octokit for swift package (https://github.com/nerdishbynature/octokit.swift.git) to get access to the Github API within the app. However, while it lets me get information about users and the repo it does not let me get a list of Contributors to a Repository. Any recommendations on anything I could use to do that?

tbraun1551 avatar Oct 02 '20 15:10 tbraun1551

@tbraun1551 Thanks for working on this, it's awesome. I'm not familiar with github's API or Octokit, but I took a quick look and don't see anything for pulling contributors. If you want, you can make a PR with a manual list for now, and we'll create a new issue for automating it. Don't forget to include yourself!

cambardell avatar Oct 03 '20 18:10 cambardell

Also as Japneet mentioned in #42, the contributors screen will eventually live somewhere in settings. You don't have to worry about that, I'll just move the contributors screen to the settings once you're done.

cambardell avatar Oct 03 '20 19:10 cambardell

Hi @tbraun1551, GitHub's REST API has an endpoint for contributions listings for a repo. https://developer.github.com/v3/repos/#list-repository-contributors Maybe this helps.

JapneetSingh5 avatar Oct 16 '20 20:10 JapneetSingh5

Thanks Japneet

cambardell avatar Oct 18 '20 01:10 cambardell