i3-weather icon indicating copy to clipboard operation
i3-weather copied to clipboard

Add km/h for windspeed

Open camponez opened this issue 6 years ago • 5 comments

camponez avatar Jan 31 '19 09:01 camponez

Should this be split into a PR upstream to pyowm to support km_h as a wind unit and one here to reference that?

On Thu, Jan 31, 2019, 01:43 Eduardo Elias <[email protected] wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/calzoneman/i3-weather/pull/19 Commit Summary

  • Add km/h for windspeed

File Changes

Patch Links:

  • https://github.com/calzoneman/i3-weather/pull/19.patch
  • https://github.com/calzoneman/i3-weather/pull/19.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calzoneman/i3-weather/pull/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXiiCPaCNvqdkscobJ72D7vMXquCeHzks5vIrq2gaJpZM4ab7XX .

calzoneman avatar Jan 31 '19 16:01 calzoneman

Should this be split into a PR upstream to pyowm to support km_h as a wind unit and one here to reference that?

Makes sense. I will update this PR as soon as I get it accepted at pyowm

camponez avatar Jan 31 '19 16:01 camponez

The change got merged into pyowm.

May need to wait until next release (>2.10.0) to get merged

camponez avatar Feb 02 '19 15:02 camponez

Do you know when the new pyowm will be released? I hate to leave your PR sitting around if the pyowm dev isn't planning to release for a while.

calzoneman avatar Feb 09 '19 04:02 calzoneman

Do you know when the new pyowm will be released? I hate to leave your PR sitting around if the pyowm dev isn't planning to release for a while.

Sorry, but I have no idea. :/

camponez avatar Feb 09 '19 09:02 camponez