calyx
calyx copied to clipboard
calyxir
Remove duplicate ops from lib.rs.
@nathanielnrn I think you're code is the only bit of rust code which is still needed. I've tried to port it over but it seems to fail tests, but I suspect this is because it simply has a different output!
Can you verify the behavior in this commit is what's intended? My sed is not good enough to confidently figure out what the addition does and reason about it myself.
So, just removed the new sed command. I think (in part based on the comment and what it was doing) it was just kind of cleaning up a file to make it a bit more readable.
I don't think that codepath was being taken in the current tests (which I think go through Rhai entirely right now).
So yeah, I'm of mind to just go ahead and remove the lib.rs now!
Nothing's blocking this other than a review and me forgetting to ask someone for one.
Okay, so this is broken still because I think it will die if it compiles without "migrate_to_scripts" set. I think the course of action is to fix that and then just merge it (hopefully like this weekend or something like that).
@jku20 can you say a bit more what this mean? I would like to get this merged.
Currently lib.rs defines build_driver which I removed. This means when migrate_to_scripts isn’t set, the fud2 doesn’t compile. The fix is as simple as removing the compile option and all the references to build_driver. I should really just do that today (haven’t gotten around to it because had a pretty hectic couple weeks).