calyx icon indicating copy to clipboard operation
calyx copied to clipboard

`ir::Builder::add_group()` should take a done condition

Open calebmkim opened this issue 3 years ago • 1 comments
trafficstars

Since we know that every group must have a group[done] = ... assignment, the ir::Builder::add_group() function should take arguments for the group's done condition.

In fact, it may even be useful to have add_group() take a Vec<ir::Assignment> argument for the group's assignments, although there may be drawbacks to this that I'm not thinking of.

calebmkim avatar Jul 20 '22 18:07 calebmkim

We should handle #864 when we fix this

rachitnigam avatar Nov 13 '22 19:11 rachitnigam