Calvin Alkan

Results 44 comments of Calvin Alkan

@jeffpaul Our library [snicco/better-wpdb](https://github.com/snicco/snicco/tree/master/src/Snicco/Component/better-wpdb) now has [support for batch processing with db locks](https://github.com/snicco/snicco/tree/master/src/Snicco/Component/better-wpdb#batchprocess). The prerequisite is PHP7.4

Just bump to at least 7.2...

> If a hash was used, I think it'd need to use a dedicated constant. Otherwise it wouldn't be possible to rotate the WP salts without requiring users to setup...

> @dd32 > > > b) meta_value being copied to another user (rare human error, which I can't realistically see being an issue that matters) > > It's called a...

@iandunn your latest commit will make it impossible to ever rotate salts.

> > > If a hash was used, I think it'd need to use a dedicated constant. Otherwise it wouldn't be possible to rotate the WP salts without requiring users...

I had the same issue. I then dug deep into the add_choices method and found the issue. `public function addChoices($choices) { if (func_num_args() > 1) { $choices = func_get_args(); }...

@danielbachhuber @johnbillion I created https://github.com/snicco/better-wp-cli for usage in our plugins which solved this issue and another closely related issue, which is that errors, warnings, etc. are sent to stdout instead...

As this is a SECURITY plugin I say PHP7.4 (only because I know 8.0 won't Happen)