Calvin Lau

Results 20 comments of Calvin Lau

> some checks are failing It's from another file. Fixing it here: https://github.com/crypto-org-chain/cronos/pull/679 and we can merge this PR I believe.

> @calvinaco should we clarify that the `extraData` should be encoded outside of the evm call and passed into the contract call as the input, otherwise if the contract encoded...

@adu-crypto @yihuang If there's no other concerns I think we can merge this.

One requirement / discussion to add is a timeout for the batch. Say if a batch has been unchanged for say n hours, the relayer should still submit the batch.

> The user sending the "bad transaction" will lose money Lose money means the bridged funds are lost too?

Another bold idea: Can we record the reverted Tx when we ignore the error thrown during batch execution? Then we can allow the sender to "claim" the bridged token by...

It could be related to this issue? https://github.com/cosmos/cosmos-sdk/pull/16639

Copying the findings from last re-indexing here > ## Partial Re-index On Specific Projections > > - Transaction > - AccountMessage > - AccountTransaction > - IBCChannel (IBCChannelTxMsgTrace for staging)...